Skip to content

Remove unused AssignDesugar span #148208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2025
Merged

Remove unused AssignDesugar span #148208

merged 1 commit into from
Oct 29, 2025
+11 −19

Conversation

@camsteffen
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Oct 28, 2025

Some changes occurred in match lowering

cc @Nadrieril

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 28, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 28, 2025

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Oct 28, 2025

Changes to the size of AST and/or HIR nodes.

cc @nnethercote

@wesleywiser
Copy link
Member

Nice find!

@bors r+ rollup=never

AST type sizes are often perf sensitive

@bors
Copy link
Collaborator

bors commented Oct 28, 2025

📌 Commit a45c6dd has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2025
@bors
Copy link
Collaborator

bors commented Oct 29, 2025

⌛ Testing commit a45c6dd with merge 907705a...

@bors
Copy link
Collaborator

bors commented Oct 29, 2025

☀️ Test successful - checks-actions
Approved by: wesleywiser
Pushing 907705a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 29, 2025
@bors bors merged commit 907705a into rust-lang:master Oct 29, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Oct 29, 2025
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 044d68c (parent) -> 907705a (this PR)

Test differences

Show 6 test diffs

6 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 907705abea355952d84ed39cea256ed4570bdda6 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-msvc: 5783.6s -> 7432.6s (28.5%)
  2. dist-aarch64-apple: 6393.5s -> 7966.2s (24.6%)
  3. dist-apple-various: 2986.2s -> 3461.8s (15.9%)
  4. x86_64-msvc-2: 6482.2s -> 7127.4s (10.0%)
  5. dist-i586-gnu-i586-i686-musl: 5369.8s -> 4846.0s (-9.8%)
  6. x86_64-gnu-tools: 3681.7s -> 3330.3s (-9.5%)
  7. dist-ohos-armv7: 4103.3s -> 4492.3s (9.5%)
  8. pr-check-2: 2545.7s -> 2315.7s (-9.0%)
  9. aarch64-gnu: 7079.1s -> 6489.9s (-8.3%)
  10. aarch64-msvc-2: 5614.1s -> 5166.1s (-8.0%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@bors bors mentioned this pull request Oct 29, 2025
Open
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (907705a): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.5% [1.5%, 1.5%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 0.9%, secondary 0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 2.2% [2.2%, 2.2%] 1
Regressions ❌
(secondary)		 4.5% [4.5%, 4.5%] 1
Improvements ✅
(primary)		 -0.5% [-0.5%, -0.5%] 1
Improvements ✅
(secondary)		 -1.7% [-1.7%, -1.6%] 2
All ❌✅ (primary) 0.9% [-0.5%, 2.2%] 2

Cycles

Results (secondary 2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 4.7% [2.6%, 6.6%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.8% [-4.8%, -4.8%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.307s -> 474.692s (0.08%)
Artifact size: 390.07 MiB -> 390.07 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@wesleywiser wesleywiser

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

6 participants

@camsteffen @rustbot @rust-log-analyzer @wesleywiser @bors @rust-timer